findAvailableLocale refactor - Removed the static function from the API and added a member function #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
reviewed
Jun 17, 2021
mvaligursky
approved these changes
Jun 17, 2021
… of fallback languages
|
You should add some tests for this in |
|
@vkalpias Added tests :) |
vkalpias
reviewed
Jul 1, 2021
| expect(app.i18n.findAvailableLocale('no-IT')).to.equal('no-IT'); | ||
| }); | ||
|
|
||
| it('findAvailableLocale() should fallback to en-US if translations have not been provide for the desired locale', function () { |
There was a problem hiding this comment.
Suggested change
| it('findAvailableLocale() should fallback to en-US if translations have not been provide for the desired locale', function () { | |
| it('findAvailableLocale() should fallback to en-US if translations have not been provided for the desired locale', function () { |
vkalpias
approved these changes
Jul 1, 2021
This was referenced Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://forum.playcanvas.com/t/playcanvas-api-function-not-working/20738
I can't think why this was public as static function as the only way to use it would be to access private member properties on i18n.
Added a member version of the function that checks against loaded translations.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.