Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore maxlines in linebreak logic on text elements #3251

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Ignore maxlines in linebreak logic on text elements #3251

merged 1 commit into from
Jun 18, 2021

Conversation

yaustar
Copy link
Contributor

@yaustar yaustar commented Jun 18, 2021

Fixes #3250

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@yaustar yaustar added bug area: ui UI related issue labels Jun 18, 2021
@yaustar yaustar requested review from slimbuck and a team June 18, 2021 14:43
@yaustar yaustar self-assigned this Jun 18, 2021
mvaligursky
mvaligursky approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

@yaustar yaustar merged commit f8e9296 into master Jun 18, 2021
@yaustar yaustar deleted the wraplines-maxlines-bug branch June 18, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@yaustar yaustar

Labels
area: ui UI related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with entity.element.text and wrap lines
3 participants
@yaustar @mvaligursky @steveny-sc