Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine example - cleaned up and converted to render components #3257

Merged
merged 18 commits into from
Jun 24, 2021
Merged

Engine example - cleaned up and converted to render components #3257

merged 18 commits into from
Jun 24, 2021

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jun 22, 2021 •
edited

Few engine examples were:

  • converted to use render component (instead of model)
  • cleaned up and tweaked
  • prettified

@mvaligursky mvaligursky self-assigned this Jun 22, 2021
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Jun 22, 2021
slimbuck
slimbuck approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with small comments

examples/src/examples/camera/fly.tsx Outdated Show resolved Hide resolved
examples/src/examples/camera/fly.tsx Outdated Show resolved Hide resolved
mvaligursky and others added 3 commits June 23, 2021 03:56
@mvaligursky @slimbuck
Update examples/src/examples/camera/fly.tsx
89bd364 
Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com>
missed last updated example
c8bdcb1
@mvaligursky @slimbuck
Update examples/src/examples/camera/fly.tsx
93e08af 
Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com>
@mvaligursky mvaligursky merged commit 8edddb3 into master Jun 24, 2021
@mvaligursky mvaligursky deleted the mvaligursy-examples-cleanup branch June 24, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@ellthompson ellthompson ellthompson approved these changes

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mvaligursky @willeastcott @ellthompson @slimbuck