-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AnimComponent] Layer masks #3264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
reviewed
Jul 22, 2021
mvaligursky
reviewed
Jul 22, 2021
mvaligursky
reviewed
Jul 23, 2021
mvaligursky
reviewed
Jul 23, 2021
mvaligursky
reviewed
Jul 23, 2021
mvaligursky
reviewed
Jul 23, 2021
mvaligursky
reviewed
Jul 23, 2021
mvaligursky
reviewed
Jul 23, 2021
mvaligursky
reviewed
Aug 12, 2021
mvaligursky
reviewed
Aug 12, 2021
mvaligursky
reviewed
Aug 12, 2021
mvaligursky
reviewed
Aug 12, 2021
mvaligursky
reviewed
Aug 12, 2021
mvaligursky
reviewed
Aug 12, 2021
mvaligursky
approved these changes
Aug 13, 2021
ellthompson
force-pushed
the
anim-layer-masks
branch
from
August 13, 2021 15:36
4012242
to
1ef938d
Compare
ellthompson
added a commit
that referenced
this pull request
Oct 12, 2021
This reverts commit 3684936.
slimbuck
pushed a commit
that referenced
this pull request
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for masks in anim component layers. It also adds support for the additive blending of layers using each layers weight property.
Below you can see a character with two animation layers. The first layer contains a blend tree which blends between an idle and running pose. This layer animations the full character body. The second layer contain a wave animation which has been masked to the characters upper body. You can see that the character blends into an upper body wave animation while still maintaining smooth blending between the full body idle and running animations.
Untitled.mov
Updated API
New API
Masks
Masks are an array of engine property paths which should all be animated by a given layer. If a mask is omitted a layer will animate all of the properties it contains curves for. Each path in the mask can have one of two forms; object or string:
If a path is a string, that path will be included in the mask. If it is an object which contains a path and children property, that path and all of its children will be included in the mask.
Fixes #1727
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.