Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basis lazyInit #3288

Merged
merged 3 commits into from
Jul 2, 2021
Merged

Basis lazyInit #3288

merged 3 commits into from
Jul 2, 2021

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Jul 2, 2021

This PR follows on from #3277. It introduces the following changes:

  • add lazyInit flag to basisInitialize config
  • add the deprecated basisSetDownloadConfig function

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@slimbuck slimbuck requested a review from a team July 2, 2021 09:02
@slimbuck slimbuck self-assigned this Jul 2, 2021
@slimbuck slimbuck changed the title Basis bc Basis lazyInit Jul 2, 2021
willeastcott
willeastcott reviewed Jul 2, 2021
View reviewed changes
src/resources/basis.js Outdated Show resolved Hide resolved
@slimbuck slimbuck merged commit 2125940 into playcanvas:master Jul 2, 2021
@slimbuck slimbuck deleted the basis-bc branch July 2, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slimbuck @willeastcott