Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose node names to Spector captures in debug mode #3300

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Expose node names to Spector captures in debug mode #3300

merged 1 commit into from
Jul 6, 2021

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 6, 2021 •
edited

  • removed unused parameter to popMarker
  • added marker for node name
  • gave skybox entity a name

Screenshot 2021-07-06 at 11 50 25

@mvaligursky mvaligursky self-assigned this Jul 6, 2021
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Jul 6, 2021
@mvaligursky mvaligursky merged commit 1ad06f4 into master Jul 6, 2021
@mvaligursky mvaligursky deleted the mvaligursky-spector-nodenames branch July 6, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @willeastcott