Always reset internal asset and model references on ModelComponent onRemove #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
approved these changes
Oct 6, 2021
mvaligursky
added
the
release: next minor
willeastcott
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes playcanvas/editor#159 and playcanvas/editor#365.
This PR fixes issues on
modelinstances not being correctly "freed" when aModelComponentis deleted by always callingmodelandassetsetters tonullwhen the component is removed/deleted. Although in most casesmodelComponent.modelwould never be set whenmodelComponent.typeisasset, this is not guaranteed.The two issues linked above happen because the Collision "preview" models are created in code, but are not properly freed because the
typeis left atasset(which is the default). There are actually multiple ways of fixing those particular bugs (like setting a custom value totype, or manually settingmodelComponent.modeltonullon the CollisionComponent), but this fixes the most underlying issue.I confirm I have read the contributing guidelines and signed the Contributor License Agreement.