Omni shadows for clustered lights #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
|
This is amazing! I've checked recently clustered for Omni lights and noticed it supports only linear falloff. |
willeastcott
reviewed
Oct 5, 2021
| @@ -37,5 +37,5 @@ vec3 getCookie2DClustered(sampler2D tex, mat4 transform, float intensity, bool i | |||
| vec4 projPos = transform * vec4(vPositionW, 1.0); | |||
| projPos.xy /= projPos.w; | |||
| vec4 pixel = mix(vec4(1.0), texture2D(tex, projPos.xy), intensity); | |||
| return isRgb ? pixel.rgb : vec3(dot(pixel, cookieChannel)); | |||
| return isRgb == true ? pixel.rgb : vec3(dot(pixel, cookieChannel)); | |||
There was a problem hiding this comment.
Why do you need to add the == true here?
There was a problem hiding this comment.
to be honest, I'm not sure, but have noticed one branch was not taken correctly unless I added it. So I added it to all. I could not find a different workaround.
There was a problem hiding this comment.
TBH, if I was refactoring this code, I would delete this. So if it's important, I would add a comment to say why it's there.
willeastcott
reviewed
Oct 5, 2021
willeastcott
reviewed
Oct 5, 2021
willeastcott
reviewed
Oct 5, 2021
willeastcott
reviewed
Oct 5, 2021
willeastcott
approved these changes
Oct 5, 2021
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clustered omni lights now support shadows by rendering them to the shadow atlas (shared with the spot lights)