[Fix] Fix to texture based morph targets to occasionally morph incorrect vertex #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvaligursky
commented
Oct 6, 2021
mvaligursky
commented
- fix involves adding a small fraction to the number to garantee it does not get converted to number one smaller. Typical workaround for these situations.
slimbuck
approved these changes
Oct 6, 2021
willeastcott
approved these changes
Oct 6, 2021
willeastcott
reviewed
Oct 6, 2021
| @@ -9,6 +9,9 @@ import { getApplication } from '../framework/globals.js'; | |||
|
|
|||
| import { BUFFER_STATIC, TYPE_FLOAT32, SEMANTIC_ATTR15, ADDRESS_CLAMP_TO_EDGE, FILTER_NEAREST, PIXELFORMAT_RGBA16F, PIXELFORMAT_RGB32F } from '../graphics/constants.js'; | |||
|
|
|||
| // value added to floats which are used as ints on the shader side to avoid values being rounded to one less occasionally | |||
| const _floatRounding = 0.2; | |||
There was a problem hiding this comment.
Just curious, but why 0.2 specifically?
There was a problem hiding this comment.
For example for number 10, it's 10.2, which is roughly in the middle between 10 and 10.5, so any rounding / precision loss should bring it to 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.