Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cubemap cookie texture in Lights example #3548

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Cubemap cookie texture in Lights example #3548

merged 3 commits into from
Oct 6, 2021

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 6, 2021 •
edited

Screenshot 2021-10-06 at 15 05 52

@mvaligursky mvaligursky marked this pull request as draft October 6, 2021 11:35
@mvaligursky mvaligursky self-assigned this Oct 6, 2021
@mvaligursky mvaligursky added area: examples area: graphics Graphics related issue labels Oct 6, 2021
@mvaligursky mvaligursky marked this pull request as ready for review October 6, 2021 14:09
@mvaligursky mvaligursky requested a review from a team October 6, 2021 14:09
willeastcott
willeastcott reviewed Oct 6, 2021
View reviewed changes
examples/src/examples/graphics/lights.tsx
assets.xmas_posz.id, assets.xmas_negz.id
]
});
cubemapAsset.loadFaces = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this property public API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question and it's not. @slimbuck - what are you thoughts on this - should we make it public or will this get refactored at some point?

@mvaligursky mvaligursky merged commit 5b14ece into master Oct 6, 2021
@mvaligursky mvaligursky deleted the mvaligursky-lights-example-cubemap-cookie branch October 6, 2021 14:17
@mvaligursky mvaligursky mentioned this pull request Oct 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: examples area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @willeastcott