Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] RenderComponent#clone should respect enabled property #4004

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[FIX] RenderComponent#clone should respect enabled property #4004

merged 1 commit into from
Feb 9, 2022

Conversation

willeastcott
Copy link
Contributor

Fixes #3888

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott added bug area: graphics Graphics related issue labels Feb 9, 2022
@willeastcott willeastcott self-assigned this Feb 9, 2022
mvaligursky
mvaligursky approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good, but ideally we address all components in a consistent way

@willeastcott
Copy link
Contributor Author

For sure. And all components should have a unit test for cloning functionality.

@willeastcott willeastcott merged commit d89c6d5 into dev Feb 9, 2022
@willeastcott willeastcott deleted the fix-render-enabled branch February 9, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@willeastcott willeastcott

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clone() doesn't respect the disabling of a render component
2 participants
@willeastcott @mvaligursky