Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JSDoc comments for sound modules #4008

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Improve JSDoc comments for sound modules #4008

merged 2 commits into from
Feb 10, 2022

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Feb 9, 2022 •
edited

  • Refactor sound code to assume presence of Web Audio API and only fix up classes if it's not available (IE11).
  • Improve quality of JSDoc comments to enable IntelliSense and correct type declarations.
  • Upgrade calls to deprecated Web Audio API to the recommended API.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott requested a review from a team February 9, 2022 22:48
@willeastcott willeastcott self-assigned this Feb 9, 2022
@willeastcott willeastcott mentioned this pull request Feb 9, 2022
Closed
@willeastcott willeastcott merged commit 42aea13 into dev Feb 10, 2022
@willeastcott willeastcott deleted the sound-jsdoc branch February 10, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@willeastcott willeastcott

Labels
area: audio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willeastcott @slimbuck