Material#clone: return polymorphic this type #4016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one issue in #3995
Before you had to write:
Now its just:
And the type is correctly inferred:
Because the type system can infer the correct type from
this
: https://www.typescriptlang.org/docs/handbook/advanced-types.html#polymorphic-this-typesJSDoc doesn't support
this
as type yet, but I made a PR for that too: playcanvas/playcanvas-jsdoc-template#38I confirm I have read the contributing guidelines and signed the Contributor License Agreement.