Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Revert changes to ScriptType and patch type declarations #4023

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

willeastcott
Copy link
Contributor

Revert attempt to correctly type optional ScriptType functions. For now, just patch the generated script-type.d.ts file with the correct typings. Perhaps a better solution can be subsequently determined.

Fixes #4020

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott merged commit e84bff3 into dev Feb 15, 2022
@willeastcott willeastcott deleted the revert-script-type branch February 15, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES6-style script definition is not working anymore in v1.52.1
2 participants