instantiateRenderEntity sets up render assets on render components

[mvaligursky]

• When an Entity hierarchy was created using GlbContainer.instantiateRenderEntity, the render component didn't have .asset property set up. This is now fixed, and those properties point to a render assets.

[willeastcott]

Wait, what's the type of the resource of a render asset? e.g. entity.render.asset?

[mvaligursky]

Wait, what's the type of the resource of a render asset? e.g. entity.render.asset?

the code I added assigns Asset type to it created here:

engine/src/resources/parser/glb-container-resource.js

Lines 58 to 65 in d5bef0e

	static createAsset(assetName, type, resource, index) {
	const subAsset = new Asset(assetName + '/' + type + '/' + index, type, {
	url: ''
	});
	subAsset.resource = resource;
	subAsset.loaded = true;
	return subAsset;
	}

But internally this is stored as an id on the component, and render.asset returns asset.id

[willeastcott]

I meant, is the asset's resource a Render? Just wondering, because that type is not public API.

[mvaligursky]

I meant, is the asset's resource a Render? Just wondering, because that type is not public API.

Fair point. Making the Render class public.

[willeastcott]

Are developers expected to create Render objects themselves? Or do anything with them? Is the Render API in 'final' form?

[mvaligursky]

I'm hiding the constructor as well .. as there's not a big use case for its public use.
Otherwise only meshes properties is exposed .. and I think that's useful to have.

[slimbuck]

Do we need to make Render class public API?

Looks like instances of Render are created by the glb-parser at load time and then used by the render component internally (via asset.resource).

Even though the Render class seems simple and innocuous enough, it's not actually possible to set a Render instance directly on the RenderComponent anyway. So seems like we can leave Render private?

[willeastcott]

I'd probably agree with that assessment. Making Render public is not necessary to solve the original motivation for this PR.