Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Removed children are no longer marked as enabled in hierarchy #4047

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Feb 24, 2022

Fixes #2464��

When a child GraphNode is removed from the parent, the removed hierarchy nodes have _enabledInHierarchy set to false. Without this, when any node is added to this removed hierarchy, it's believed to be active.

@mvaligursky mvaligursky self-assigned this Feb 24, 2022
@mvaligursky mvaligursky added area: graphics Graphics related issue bug labels Feb 24, 2022
@mvaligursky mvaligursky requested a review from a team February 24, 2022 14:50
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly scared about weird edge cases/side effects here, but in principle, seems good.

@mvaligursky mvaligursky merged commit 2486bdd into dev Feb 24, 2022
@mvaligursky mvaligursky deleted the mvaligursky-remove-activeinhierarchy branch February 24, 2022 15:16
jpauloruschel added a commit that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an entity to a unparented entity will cause the child to render
2 participants