Fix AudioContext not being properly resumed on iOS 15. #4062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
previously approved these changes
Feb 28, 2022
jpauloruschel
force-pushed
the
jpaulo-fix-ios-audio-from-sleep
branch
from
d74c8ac
to
2c1dacd
Compare
jpauloruschel
dismissed
willeastcott’s stale review
Breaking changes were added which require another review.
mvaligursky
reviewed
Mar 2, 2022
mvaligursky
reviewed
Mar 2, 2022
|
Please test this on IE11 as well .. as that could behave differently too (if not already) |
jpauloruschel
force-pushed
the
jpaulo-fix-ios-audio-from-sleep
branch
from
4541e7d
to
094f154
Compare
mvaligursky
reviewed
Mar 2, 2022
mvaligursky
reviewed
Mar 2, 2022
mvaligursky
reviewed
Mar 2, 2022
mvaligursky
approved these changes
Mar 2, 2022
slimbuck
approved these changes
Mar 2, 2022
| this._resumeContext = () => { | ||
| if (!this.context || this.context.state === 'running') { | ||
| USER_INPUT_EVENTS.forEach((eventName) => { | ||
| window.removeEventListener(eventName, this._resumeContext); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3977
Fix issues on the
AudioContextnot being properly resumed, especially on iOS 15. This is done by explicitly calling.resume()on theAudioContextwhen required. Extra checks were added to make sureresumeis only called when the window is being re-focused, and the state is going fromsuspendedorinterruptedback torunning- otherwise exceptions are thrown. Additionally, if for any reason the context can't be resumed successfully, the Auto-Play event listeners are re-bound so that the audio can be resumed later.Documentation:
As far as I could test, this new code behaves well with all of our current target devices and browsers, but we could also consider using external libraries for this kind of stuff, such as the ones below (pending analysis, of course).
New test scenarios in Safari iOS 15:
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.