-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking][Anim Component] Layer blending update #4064
Conversation
I wonder if we could handle this as non-breaking change? If normalizeWeights is undefined (existing assets), we should assume it's true. For new assets this will be initialized to false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, I'm approving it.
But before the merge, I would just want to double check this is a breaking change and cannot be done as non-breaking. I think you explained it cannot, but please consider it one more time.
This PR adds the option to toggle the normalisation of layer weights on or off.
If weight normalisation is turned on the algorithm functionality is the same as before:
If weight normalisation is turned off the following effects take place:
The default setting going forward will be not to normalize weights. As the anim component will no longer use the previous blending algorithm as the default, this PR becomes a breaking change. If users wish to use the old blending algorithm, they will be required to set the
normalizeWeights
property totrue
.This PR creates new public API:
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.