Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalize callback types #4072

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Capitalize callback types #4072

merged 1 commit into from
Mar 1, 2022

Conversation

willeastcott
Copy link
Contributor

This PR capitalizes the types of callbacks in the engine, which feels more consistent with the rest of the API.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott requested a review from a team March 1, 2022 13:42
@willeastcott willeastcott self-assigned this Mar 1, 2022
slimbuck
slimbuck approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might this break existing ts applications which declare variables of these types? If so, might be worth adding typedefs somewhere to the old names.

@willeastcott willeastcott merged commit 7f128f2 into dev Mar 1, 2022
@willeastcott
Copy link
Contributor Author

@slimbuck I don't think so because callbacks had different names in 1.51 anyway (namespaced as callbacks.*).

@willeastcott willeastcott deleted the capitalize-callbacks branch March 1, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@willeastcott willeastcott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willeastcott @slimbuck