Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy flipV code in glb-parser #4079

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Mar 2, 2022

Quoting the code comment:

The very first version of FACT generated incorrectly flipped V texture
coordinates. Since this first version was only ever available behind an
editor flag there should be very few such GLB models in the wild.
Instead of bloating the engine forevermore with code to handle this case,
we now issue a warning instead and prompt user to reconvert their FBX.

@slimbuck slimbuck requested a review from a team March 2, 2022 14:58
@slimbuck slimbuck self-assigned this Mar 2, 2022
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wholeheartedly approve! 👍

@slimbuck slimbuck merged commit dcbfd71 into playcanvas:dev Mar 2, 2022
@slimbuck slimbuck deleted the remove-flipv branch March 2, 2022 15:48
slimbuck pushed a commit that referenced this pull request Apr 27, 2022
slimbuck pushed a commit that referenced this pull request Jun 2, 2022
slimbuck pushed a commit to slimbuck/engine that referenced this pull request Jun 9, 2022
slimbuck added a commit that referenced this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants