Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vec3 Support for setFromEulerAngles() pc.Quat function #4139

Merged
merged 7 commits into from
Mar 22, 2022
Merged

Add Vec3 Support for setFromEulerAngles() pc.Quat function #4139

merged 7 commits into from
Mar 22, 2022

Commits on Mar 17, 2022

  1. Add Vec3 Support for setFromEulerAngles() pc.Quat function

    @zishiwu123
    zishiwu123 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    ee71323 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'playcanvas:main' into make-quat-from-vec3

    @zishiwu123
    zishiwu123 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    7f7c8a7 View commit details
    Browse the repository at this point in the history

  3. safer instantiation of Quat based on Vec3

    @zishiwu123
    zishiwu123 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    4a6637b View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. simplify use of Quat.setFromEulerAngles when input is Vec3 

    Thanks to @kungfooman for the suggestion to simplify use.
Thanks to @Maksims for pointing out no need to clone when
input is Vec3, just a reference is enough.
    @zishiwu123
    zishiwu123 committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    aceaaec View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. remove checks for instanceof Vec3 in graph-node 

    No longer need to check if x instanceof Vec3 when x is passed
as input to setFromEulerAngles() pc.Quat function.
    @zishiwu123
    zishiwu123 committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    f9dfb0c View commit details
    Browse the repository at this point in the history

  2. Mark parameters ey and ez as optional

    @zishiwu123
    zishiwu123 committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    44a90d0 View commit details
    Browse the repository at this point in the history

  3. Update quat.js

    @willeastcott
    willeastcott committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    0801ce7 View commit details
    Browse the repository at this point in the history