Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line rendering - avoid spread operator on large arrays #4173

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 4, 2022

@mvaligursky mvaligursky self-assigned this Apr 4, 2022
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Apr 4, 2022
@mvaligursky mvaligursky merged commit 6bac479 into main Apr 4, 2022
@mvaligursky mvaligursky deleted the mvaligursky-many-lines branch April 4, 2022 15:08
@LeXXik
Copy link
Contributor

LeXXik commented Jun 27, 2022

@mvaligursky I am still unable to render large arrays of lines. Not sure if the issue is the same or a new one, let me know if you want a new issue. The lines do render, but I get assert errors.

image

@mvaligursky
Copy link
Contributor Author

That means the number of colors does not match the number of positions. I'd double check you're passing the array of equal length to the line drawing. But could be something else, in which case a repro would be great.

@LeXXik
Copy link
Contributor

LeXXik commented Jun 28, 2022

I will debug it on my side first then.

@mvaligursky yes, you were correct. I missed the alpha value for colors, making it a mismatch. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants