enable support for retrying loading of container assets #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for this @vfernandestoptal it's awesome! |
|
hey, any update on when this might get merged and released? |
slimbuck
reviewed
Apr 19, 2022
willeastcott
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While tracking down an issue with my project, I noticed that playcanvas was not automatically retrying loading of GLB files when there was a network failure, like it does for other assets like texture files for instance.
This PR updates the
ContainerHandlerclass to support updatingmaxRetriesand forward it to any configured parsers, including theGlbParser, to which it delegates the loading of the asset by default.I confirm I have read the contributing guidelines and signed the Contributor License Agreement.