Envatlas mipmap fix #4193
Merged
Envatlas mipmap fix #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generate a 1-pixel border around equirect mipmaps in the envatlas and must be careful not to rely on smaller mips which are predominantly mipmap border (i.e. sizes 1x1, 2x2, 4x4).
This PR removes the last level of mipmap we were relying on from the shiny reflections, because it was causing unruly aliasing on thin sliver polygons.
Here is a closeup of a vehicle under harsh lighting conditions demonstrating the aliasing before and after: