[Anim Component] Fix for the normalizeWeights property #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaustar
reviewed
Apr 20, 2022
| // clear all targets from previous binding | ||
| this._targets = {}; | ||
| } | ||
|
|
||
| resetStateGraph() { | ||
| const assetId = this._stateGraphAsset; |
There was a problem hiding this comment.
Was this tested against the model component when it isn't playing?
| this.removeStateGraph(); | ||
| if (this.stateGraphAsset) { | ||
| if (assetId) { | ||
| const stateGraph = this.system.app.assets.get(this.stateGraphAsset).resource; |
There was a problem hiding this comment.
Suggested change
| const stateGraph = this.system.app.assets.get(this.stateGraphAsset).resource; | |
| const stateGraph = this.system.app.assets.get(assetId).resource; |
Should this be assetId instead?
| @@ -475,6 +474,14 @@ class AnimComponent extends Component { | |||
| } | |||
| } | |||
|
|
|||
| unbind() { | |||
| if (!this._normalizeWeights) { | |||
There was a problem hiding this comment.
Given the function name unbind, it would imply it would unbind regardless of _normalizeWeights. Do we want the if check here or in the setter of normalizeWeights?
There was a problem hiding this comment.
We'd want this check any time unbind is called (currently changing the normalizeWeights property or removing the state graph).
yaustar
reviewed
Apr 20, 2022
| if (this.stateGraphAsset) { | ||
| const stateGraph = this.system.app.assets.get(this.stateGraphAsset).resource; | ||
| if (assetId) { | ||
| const stateGraph = this.system.app.assets.get(assetId).resource; | ||
| this.loadStateGraph(stateGraph); |
There was a problem hiding this comment.
_stateGraphAsset is still null after this call. Should we set this prior to the call?
slimbuck
pushed a commit
that referenced
this pull request
Apr 21, 2022
* fix for the normalizeWeights anim component property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when setting the normalizeWeights property, the state graph was reset in order to unbind any dirty targets it contained. This PR moves the target unbinding to its own function so that the normalizeWeights setter can call it directly. It also removes the resetStateGraph function which is no longer necessary.
Fixes #4189
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.