Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy XR-DepthSensing texture when Application is destroyed #4207

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Destroy XR-DepthSensing texture when Application is destroyed #4207

merged 1 commit into from
Apr 22, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 22, 2022 •
edited

  • XR-DepthSensing texture gets destroyed when Application is destroyed
  • small cleanup to pass texture name in options for all engine created textures

@mvaligursky
Copy link
Contributor Author

slightly related to #4135 (even though that one likely does not allocated any gfx resources)

@mvaligursky mvaligursky self-assigned this Apr 22, 2022
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Apr 22, 2022
@mvaligursky mvaligursky requested a review from a team April 22, 2022 11:09
@slimbuck
Copy link
Member

This is great! Though I'd love to see 'name' specified as the first option everywhere.

@mvaligursky mvaligursky merged commit 00e1f56 into main Apr 22, 2022
@mvaligursky mvaligursky deleted the mvaligursky-texture-name branch April 22, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvaligursky @slimbuck @willeastcott