Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved vertex color handling for GLB files #4209

Merged
merged 2 commits into from
Apr 23, 2022
Merged

Improved vertex color handling for GLB files #4209

merged 2 commits into from
Apr 23, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 22, 2022 •
edited
Loading

Fixes #4118 (great investigation and solutions @willeastcott )

  • instead of using DefaultMaterial for missing materials inside GLB, use GLB specific default material
  • assume 8but colors in draco compressed glb format are normalized (some compressor don't set that flag correctly, I've seen it few times in the past)

@mvaligursky mvaligursky self-assigned this Apr 22, 2022
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Apr 22, 2022
@mvaligursky mvaligursky requested a review from a team April 22, 2022 14:00
@mvaligursky mvaligursky merged commit e32557f into main Apr 23, 2022
@mvaligursky mvaligursky deleted the mvaligursky-glb-vertex-colors branch April 23, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GLB vertex colors not appearing
2 participants
@mvaligursky @slimbuck