Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional performance markers & small code cleanup #4251

Merged
merged 1 commit into from
May 17, 2022
Merged

Additional performance markers & small code cleanup #4251

merged 1 commit into from
May 17, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented May 17, 2022 •
edited

  • few GPU performance markers
  • small cleanup, exposed Debug class (it contains one public function)

@mvaligursky mvaligursky self-assigned this May 17, 2022
slimbuck
slimbuck reviewed May 17, 2022
View reviewed changes
src/graphics/webgl/webgl-graphics-device.js
@@ -1242,6 +1242,8 @@ class WebglGraphicsDevice extends GraphicsDevice {
* {@link GraphicsDevice#updateEnd} must not be nested.
*/
updateBegin() {
DebugGraphics.pushGpuMarker(this, `UPDATE-BEGIN`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to shout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah .. I've decided to use capital letters for engine commands (BLIT, RESOLVE, PICKER) and similar. And use whatever user provides for Camera / Entity names as currently (usually camel syntax), to make them more distinct and cleaner in SpectorJS capture.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@mvaligursky mvaligursky merged commit 4e3bb18 into main May 17, 2022
@mvaligursky mvaligursky deleted the mvaligursky-perf-markers branch May 17, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck left review comments

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvaligursky @willeastcott @slimbuck