Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use script tag for engine in examples #4255

Merged
merged 3 commits into from
May 19, 2022
Merged

Use script tag for engine in examples #4255

merged 3 commits into from
May 19, 2022

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented May 17, 2022 •
edited
Loading

Use script tag for loading engine which makes debugging etc much easier.

Also filter out non-directories when reading category names during build.

@slimbuck slimbuck requested a review from a team May 17, 2022 17:10
@slimbuck slimbuck self-assigned this May 17, 2022
@slimbuck slimbuck changed the title Use script tag for loading engine in examples Use script tag for engine in examples May 17, 2022
ellthompson
ellthompson approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@ellthompson ellthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a single comment.

examples/scripts/iframe/index.mustache Show resolved Hide resolved
@slimbuck slimbuck merged commit 18479af into playcanvas:main May 19, 2022
@slimbuck slimbuck deleted the examples-fix branch May 19, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellthompson ellthompson ellthompson approved these changes

Assignees

@slimbuck slimbuck

Labels
area: examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slimbuck @ellthompson