Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP implementation of UniformBuffer and BindGroup #4258

Merged
merged 3 commits into from
May 24, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented May 18, 2022

Partially implements: #4261

  • initial WIP implementation of mentioned classes. The code is behind device.supportsUniformBuffer flag which is false for Webgl for now.
  • initial integration of the View uniform buffer (again unused)

@mvaligursky mvaligursky self-assigned this May 18, 2022
src/graphics/graphics-device.js Outdated Show resolved Hide resolved
src/graphics/uniform-buffer-format.js Show resolved Hide resolved
src/graphics/uniform-buffer.js Show resolved Hide resolved
src/scene/renderer/forward-renderer.js Outdated Show resolved Hide resolved
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some comments.

@mvaligursky mvaligursky merged commit 4f70192 into main May 24, 2022
@mvaligursky mvaligursky deleted the mvaligursky-uniform-buffer-wip branch May 24, 2022 14:32
@mvaligursky mvaligursky mentioned this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants