Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color mix in the linear fog #4283

Merged
merged 1 commit into from
May 31, 2022

Conversation

querielo
Copy link
Contributor

Colors has to be mixed in the linear space (not factor) similar to fogExp.js.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Really odd that the factor was getting gamma corrected.

@slimbuck
Copy link
Member

How very strange. Just checked the history and it seems the gammaCorrect call has been in there from the very first version. Might break existing scenes...

@willeastcott willeastcott merged commit 599355a into playcanvas:main May 31, 2022
@willeastcott
Copy link
Contributor

Thanks for this @querielo

@querielo querielo deleted the kirill/fix-fog branch May 31, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants