Element component: mark a batch group as dirty if an attribute has been changed

[querielo]

Fixes #2579

MR makes batch group dirty if an element has been changed. So, a user don't have to mark a batch group as dirty manually, because it is error-prone.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

[mvaligursky]

Looks great! I'd probably add a function like this to the class

    _dirtyBatch() {
        if (this.batchGroupId !== -1) {
            this.system.app.batcher?.markGroupDirty(this.batchGroupId);
        }
    }

and then use this

        set: function (value) {
            if (this._text && this._text[name] !== value) {
                this._text[name] = value;
                this._dirtyBatch();
            } else if (this._image && this._image[name] !== value) {
                this._image[name] = value;
                this._dirtyBatch();
            }
        }

it would allow us to call _dirtyBatch from multiple places.

[querielo]

Looks great! I'd probably add a function like this to the class

    _dirtyBatch() {
        if (this.batchGroupId !== -1) {
            this.system.app.batcher?.markGroupDirty(this.batchGroupId);
        }
    }

and then use this

        set: function (value) {
            if (this._text && this._text[name] !== value) {
                this._text[name] = value;
                this._dirtyBatch();
            } else if (this._image && this._image[name] !== value) {
                this._image[name] = value;
                this._dirtyBatch();
            }
        }

it would allow us to call _dirtyBatch from multiple places.

@mvaligursky Done

[mvaligursky]

looks like a great change to me!

[jpauloruschel]

I don't think it is safe to add this value check before setting the property. There are many setters in both text and image that do specific code depending if the values differ or not, so adding this here will probably break those functionalities.

I think it is best to add the value check difference only to the call to _dirtyBatch

[querielo]

Done: a09bb29

[jpauloruschel]

Shouldn't the callback for dirtifying be after the value is changed?

[mvaligursky]

it does not matter, this just marks it dirty .. the actual value is not used in this function.
And the batch rebuilds after all scripts are done executing.

[jpauloruschel]

Ahh ok! All good, then. Thanks, @querielo !