Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated JSDocs of AppOptions to be JSDocs compatible #4324

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Updated JSDocs of AppOptions to be JSDocs compatible #4324

merged 1 commit into from
Jun 10, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jun 10, 2022 •
edited

Fixes #4318

  • making JSDocs to be happy, even though the type is not exactly correct. I don’t see a way for other solution for now.

@mvaligursky mvaligursky self-assigned this Jun 10, 2022
@mvaligursky mvaligursky added the docs Documentation related label Jun 10, 2022
@mvaligursky mvaligursky merged commit b4932bd into main Jun 10, 2022
@mvaligursky mvaligursky deleted the mvaligursky-app-options-docs branch June 10, 2022 15:02
yaustar pushed a commit that referenced this pull request Jun 16, 2022
@mvaligursky @steveny-sc
Updated JSDocs of AppOptions to be JSDocs compatible (#4324)
2fa6b08 
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
(cherry picked from commit b4932bd)
@mvaligursky mvaligursky mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API docs don't generate on release 1.54
2 participants
@mvaligursky @willeastcott