SSAO Downscale #4339
Merged
SSAO Downscale #4339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSAO renders first to a downscaled render target, and the blur pass also outputs to a downscaled target. A last (new) pass outputs the final value to the output target. The SSAO script handles window resizing as well as changing the downscale value on-the-fly.
mvaligursky
reviewed
Jun 17, 2022
Comment on lines
+368
to
+376
| "attribute vec2 aPosition;", | ||
| "", | ||
| "varying vec2 vUv0;", | ||
| "", | ||
| "void main(void)", | ||
| "{", | ||
| " gl_Position = vec4(aPosition, 0.0, 1.0);", | ||
| " vUv0 = (aPosition.xy + 1.0) * 0.5;", | ||
| "}" |
There was a problem hiding this comment.
it seems this vertex shader is repeated 2-3x in this file .. perhaps store it in a variable and reuse?
There was a problem hiding this comment.
I am actually working on adding a createVertexShader for post effects so we can reuse it everywhere. It seems this code is the same for every post effect, so it would make sense to have it declared in a single place and reused across multiple post effects. I will add it to this PR.
There was a problem hiding this comment.
keep it is a separate PR please
|
If you have some performance / quality comments related to this change, please add them to the description, that'd be great to see. |
mvaligursky
approved these changes
Jun 17, 2022
|
Performance at 50% scale: ~1.6x faster than 100%. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds downscaling to the SSAO effect, similar to #3493 but with the addition of also performing the blur pass to a downscaled target, thus reducing the pressure on texture fetches.
It also implements the resize and reaction to changing the downscaling attribute similar to the PR mentioned above, but with the addition of adding the downscale to the post-effects.tsx example.