Fix culling on screen-space screen. #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4199
This PR fixes the way a
Screen'scullandscreenSpaceproperties are used onImageElement. I confirmed thatTextElementis working correctly.The before code was not following the logic outlined in the
ScreenAPI documentation (https://developer.playcanvas.com/en/api/pc.ScreenComponent.html#cull)in that it was ignoring the
cullproperty of the parentScreenand always culling. Additionally, thevisibleFn(used to calculate if that element is visible for a given camera) was not being set correctly for screenSpace screens.Before (https://playcanvas.com/project/913583/overview/culluitest):
After (https://playcanvas.com/project/913583/overview/culluitest):
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.