Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync screens draw order on set Priority. #4380

Merged
merged 6 commits into from
Jun 28, 2022

Conversation

jpauloruschel
Copy link
Contributor

Part of #3514

This PR makes it so the raw order of UI Elements is refreshed properly when changing a Screen's priority attribute.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@jpauloruschel jpauloruschel added bug area: ui UI related issue labels Jun 27, 2022
@jpauloruschel jpauloruschel requested a review from a team June 27, 2022 14:41
@jpauloruschel jpauloruschel self-assigned this Jun 27, 2022
@jpauloruschel jpauloruschel marked this pull request as ready for review June 27, 2022 14:45
@yaustar
Copy link
Contributor

yaustar commented Jun 27, 2022

We should expose priority as public API too :)

@jpauloruschel
Copy link
Contributor Author

We should expose priority as public API too :)

Changed in JSDocs (so it appears in API Reference) and also changed the manual: playcanvas/developer.playcanvas.com#411

@jpauloruschel jpauloruschel merged commit 1260564 into main Jun 28, 2022
@jpauloruschel jpauloruschel deleted the jpaulo-fix-ui-screen-priority branch June 28, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui UI related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants