New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted skybox functionality from Scene into Sky class #4389

Merged

mvaligursky merged 1 commit into main from mvaligursky-sky

Jun 30, 2022

Contributor

mvaligursky commented Jun 30, 2022 •

edited

also some refactor, for example no longer using a Model to store an array of mesh instances.
calling the class / instance of it in the Scene .sky instead of .skybox, as it's more generic, and Scene already contains public skybox property.


          Extracted skybox functionality from Scene into Sky class

77a71a9

mvaligursky self-assigned this

mvaligursky added the area: graphics label

mvaligursky requested review from slimbuck, willeastcott and GSterbrant

June 30, 2022 13:02

GSterbrant approved these changes

View reviewed changes

mvaligursky merged commit 5405166 into main

mvaligursky deleted the mvaligursky-sky branch

June 30, 2022 13:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment