Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of glTF extension handling #4409

Merged
merged 5 commits into from
Jul 8, 2022

Conversation

GSterbrant
Copy link
Contributor

Description

Refactors the way we deal with glTF extensions, giving us a better overview of the extensions we support and moving the inline extension handling to their own functions.

@GSterbrant GSterbrant self-assigned this Jul 8, 2022
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Jul 8, 2022
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Next step could go even further, similar to what I've done with other large files in the engine: create a folder called glb-parser, and move this file into it. Then create a file per extension in the same folder.

@GSterbrant
Copy link
Contributor Author

Yeah, that could be a good plan to prepare for the potentially big library of extensions we will support.

@GSterbrant GSterbrant merged commit d0ffbfe into main Jul 8, 2022
@GSterbrant GSterbrant deleted the gsterbrant_gltf_extensions_refactor branch July 8, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants