-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of glTF extension handling #4409
Conversation
…ng them all inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Next step could go even further, similar to what I've done with other large files in the engine: create a folder called glb-parser
, and move this file into it. Then create a file per extension in the same folder.
Yeah, that could be a good plan to prepare for the potentially big library of extensions we will support. |
Description
Refactors the way we deal with glTF extensions, giving us a better overview of the extensions we support and moving the inline extension handling to their own functions.