Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader processor improvements related to bind groups format #4410

Merged
merged 7 commits into from
Jul 11, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 8, 2022

  • bind group format and bind uniform format classes can now generate relevant shader code blocks
  • these are used to generate view uniform code blocks
  • shader processor generates new 'mesh' bind group format instances for uniforms not used by other buffers, and generates code from those too

Note: This does not execute on WebGl (currently)

@mvaligursky mvaligursky self-assigned this Jul 8, 2022
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Jul 8, 2022
Co-authored-by: Will Eastcott <will@playcanvas.com>
@mvaligursky mvaligursky added the release: next minor Ticket marked for the next minor release label Jul 11, 2022
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with small comment. Just checking, does this code gets stripped out of the built engine? (the webgpu-only stuff)

@mvaligursky
Copy link
Contributor Author

Approved with small comment. Just checking, does this code gets stripped out of the built engine? (the webgpu-only stuff)

The shader processor is stripped out for now, as its imported only by WebgpuShader, which is not part of the engine yet.
The shader processor options (small data class) is included, as this is used to pass data from forward renderer.

@mvaligursky mvaligursky merged commit 80b0b9f into main Jul 11, 2022
@mvaligursky mvaligursky deleted the mvaligursky-shaderprocess-2 branch July 11, 2022 09:02
@mvaligursky mvaligursky mentioned this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue release: next minor Ticket marked for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants