New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dot not build lighting shader if material.useLighting is false #4430

Merged

mvaligursky merged 2 commits into main from mvaligursky-uselighting

Jul 13, 2022

Contributor

mvaligursky commented Jul 13, 2022 •

edited

Loading

only generate lighting shader if material.useLighting is true. This avoids adding code which does not get used to UI and similar shaders.
disable clustered lighting in the else branch as the options object gets reused, to override previous settings.


          Dot not build lighting shader if material.useLighting is false

b568183

mvaligursky self-assigned this

mvaligursky requested review from GSterbrant, slimbuck and willeastcott

July 13, 2022 13:33

slimbuck approved these changes

View reviewed changes


          lint

93ace3f

GSterbrant approved these changes

View reviewed changes

mvaligursky merged commit 42807c1 into main

mvaligursky deleted the mvaligursky-uselighting branch

July 13, 2022 13:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment