Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill for Object.values #4482

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Conversation

kungfooman
Copy link
Collaborator

Right now not every code path is polyfilled, for example this doesn't work in IE11:

test = new pc.Entity('test');
test.addComponent('anim');
test.anim.dirtifyTargets();

Because of Object.values:

dirtifyTargets() {
const targets = Object.values(this._targets);
for (let i = 0; i < targets.length; i++) {
targets[i].dirty = true;
}
}

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott
Copy link
Contributor

willeastcott commented Aug 1, 2022

Since @ellthompson is the originator of these calls to Object.values, I've assigned this PR to him. 😄

@slimbuck slimbuck merged commit 6c1b555 into playcanvas:main Aug 1, 2022
slimbuck pushed a commit that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants