Handle refractionIndex as being one over refraction index. #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/engine into gsterbrant_refractionIndex_fix
…a constant of 1.0 if the refraction index is 0.0.
slimbuck
approved these changes
Aug 3, 2022
slimbuck
pushed a commit
that referenced
this pull request
Aug 3, 2022
* Handle refractionIndex as being one over refraction index. * Remove conditional calculation of f0 value. * Add guard against reflection index of 0. * Add guard against refraction index of 0. * (Inf - 1) / (Inf + 1) converges at 1, so a better solution is to use a constant of 1.0 if the refraction index is 0.0. * Fix lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standard material treated refractionIndex as being the actual index of refraction value, when in fact it's edited as 1.0 / IOR. So to fix that, we have to treat refractionIndex as the inverse, and calculate a correct F0 from that.