Apply polygon offset for shadows with WebGL1 #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…results identical to those of GL2 when polygon offset is applied.
GSterbrant
changed the title
slimbuck
approved these changes
Aug 15, 2022
mvaligursky
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2780
Polygon offset is enabled in GL2 when rendering shadows. However, because GL1 doesn't support polygon offset, it has to be done programatically. We supported that, but only applied polygon offset for PCF3 shadows, so to make it consistent with both GL1 and GL2, this PR applies polygon offset by default if GL1 is enabled and the device supports derivatives.
Test scene: https://playcanvas.com/editor/scene/1501582