Fix material thickness and texture transforms #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refraction index is default 1.0 / 1.5, so should only be skipped if that's the case. Thickness is only relevant if bigger than 1, since the texture can only encode 0-1.
slimbuck
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our extensions implementation were not extracting texture transforms for the textures. This would cause issues importing assets with for example gltf pack where texture transforms would be applied automatically.
Thickness was wrongfully not tinted if it was below 1, but in fact thickness is a scale factor meant to scale the texture input. As a result, the DragonAttenuation glTF looks much better.
Also, IOR would default to 0.667 in the shader if 1.5 was used, which is incorrect as it should be 1.0 / 1.5. This should be indeed VERY hard to reproduce for a user, so very unlikely anyone encountered this as an issue.