Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CC-BY-4.0 licences to asset viewer example #4610

Merged
merged 2 commits into from Sep 1, 2022

Conversation

yaustar
Copy link
Contributor

@yaustar yaustar commented Sep 1, 2022

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@yaustar yaustar requested a review from a team September 1, 2022 11:46
@yaustar yaustar self-assigned this Sep 1, 2022
@mvaligursky
Copy link
Contributor

you could also do it this way, to be more in line with other models we have?
https://github.com/playcanvas/engine/blob/main/examples/assets/models/chess-board.txt

@yaustar
Copy link
Contributor Author

yaustar commented Sep 1, 2022

I would have thought we need to add it where it's being used/viewed?

@mvaligursky
Copy link
Contributor

Not sure. This applies and does not specifies it: https://creativecommons.org/licenses/by/4.0/
I always though it better to be stored next to the file we distribute, rather than elsewhere where its referenced.

@yaustar
Copy link
Contributor Author

yaustar commented Sep 1, 2022

I change it to be consistent to be the chess board for now. We can change it all later if need be

@yaustar
Copy link
Contributor Author

yaustar commented Sep 1, 2022

@mvaligursky Added text files for the licenses

@yaustar yaustar merged commit 722352d into main Sep 1, 2022
@yaustar yaustar deleted the example-browser-add-license branch September 1, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants