Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes sheen intensity #4697

Merged
merged 7 commits into from
Oct 6, 2022
Merged

Fixes sheen intensity #4697

merged 7 commits into from
Oct 6, 2022

Commits on Oct 4, 2022

  1. Fix double clearcoat spec multiplication.

    @GSterbrant
    GSterbrant committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    932ba59 View commit details
    Browse the repository at this point in the history

  2. Use CC fresnel for lights

    @GSterbrant
    GSterbrant committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    1495be8 View commit details
    Browse the repository at this point in the history

  3. Use CC fresnel for lights

    @GSterbrant
    GSterbrant committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    d4879f4 View commit details
    Browse the repository at this point in the history

  4. Add reflection sample with base mip offset for materials

    @GSterbrant
    GSterbrant committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    ec52963 View commit details
    Browse the repository at this point in the history

  5. Defer multiplication of sheen specular color to combine step.

    @GSterbrant
    GSterbrant committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    c7815c4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'gsterbrant_sheen_spec_fixes' of github.com:playcanvas/e… 

    …ngine into gsterbrant_sheen_spec_fixes
    @GSterbrant
    GSterbrant committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    287248a View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. We don't use reciprocal PI for energy preservation, so doing it for s… 

    …heen was a mistake.

Also revert the mip offset reflection sampling.
Also, sheen should not be a factor of the materials reflectivity.
    @GSterbrant
    GSterbrant committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    6837670 View commit details
    Browse the repository at this point in the history