Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the Loaders/glb example to use physical units #4752

Merged
merged 1 commit into from Oct 14, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 14, 2022

  • as glb stores light intensity in physical units, which we now support, switch the example to use them instead of clamped intensities.

visually its the same result
Screenshot 2022-10-14 at 12 30 36

@mvaligursky mvaligursky merged commit 3c6fd37 into main Oct 14, 2022
@mvaligursky mvaligursky deleted the mv-glb-physical-units branch October 14, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants