Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small improvements and validations to WebGPU rendering #4899

Merged
merged 1 commit into from Nov 30, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Nov 30, 2022

  • shader processor handles the same uniform coming from vertex and fragment shader by de-duplication
  • validation of vertex format support on WebGPU (at some point we might need to add workaround for these when loading glbs with the format)
  • grab texture sampling temporary fix, might need to create some wrapper function for this in the future

And this now works

refraction.mov

@mvaligursky mvaligursky self-assigned this Nov 30, 2022
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Nov 30, 2022
@slimbuck
Copy link
Member

wow this awesome!

think I can see twinkles - mipmaps not yet supported?

@mvaligursky
Copy link
Contributor Author

Yep, no mipmaps .. WebGPU does not have generateMipmaps function, and that needs to be done by rendering down the mipmaps chain. Leaving that for later.

@mvaligursky mvaligursky merged commit 636571e into main Nov 30, 2022
@mvaligursky mvaligursky deleted the mv-webgpu-improvements branch November 30, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants