Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor out dependency of SceneGrab on the AppBase #4901

Merged
merged 3 commits into from Dec 2, 2022
Merged

Refactor out dependency of SceneGrab on the AppBase #4901

merged 3 commits into from Dec 2, 2022

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Dec 1, 2022 •
edited

  • The application dependency was there only to gain access to the Device and the Scene. Those are now passed directly.
  • This allowed the SceneGrab to be moved from /framework to /scene
  • Move some related logic from renderer to SceneGrab to keep it self contained - fixes render pass set up issue for WebGPU

@mvaligursky mvaligursky self-assigned this Dec 1, 2022
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Dec 1, 2022
@mvaligursky mvaligursky merged commit 1e148f6 into main Dec 2, 2022
@mvaligursky mvaligursky deleted the mv-scenegrab-move-scene branch December 2, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@GSterbrant GSterbrant Awaiting requested review from GSterbrant

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @slimbuck