Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision offset changes needed for Editor integration #4916

Merged
merged 2 commits into from Dec 9, 2022

Conversation

yaustar
Copy link
Contributor

@yaustar yaustar commented Dec 8, 2022

Fixes:

  • JS docs for linear offset which used to imply that it would be offset in local space. It actually does it in world space but along the Entity's local axes
  • On component creation, we accept euler angles as a number array of length 3 as well as a quat of length 4. This makes Editor integration a lot easier as it can store it in the data as a vec3 euler angles. Added benefit (which we should document?) is that at runtime, developers don't have to convert to a quat.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@yaustar yaustar requested review from ellthompson, mvaligursky and a team December 8, 2022 17:55
@yaustar yaustar self-assigned this Dec 8, 2022
@yaustar yaustar merged commit ec2555f into main Dec 9, 2022
@yaustar yaustar deleted the collision-offset-editor-fixes branch December 9, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants